Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace age field with DOB while Updating User #7322

Merged
merged 9 commits into from
Mar 26, 2024

Conversation

rash-27
Copy link
Contributor

@rash-27 rash-27 commented Mar 1, 2024

Proposed Changes

Screenshot 2024-03-02 043551

Screenshot 2024-03-02 043612

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rash-27 rash-27 requested a review from a team as a code owner March 1, 2024 23:29
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2024 7:48am

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 769ac1c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6603110e5136470008c11d94
😎 Deploy Preview https://deploy-preview-7322--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Mar 5, 2024

@rash-27 you need to modify the cypress test, as it's failing

@nihal467 nihal467 added changes required cypress failed pull request with cypress test failure and removed needs testing labels Mar 5, 2024
@rash-27
Copy link
Contributor Author

rash-27 commented Mar 10, 2024

Screenshot from 2024-03-10 13-14-23
Screenshot from 2024-03-10 13-13-11
@nihal467 please review it (tests are modified based on change with the backend pr #1935)

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

Copy link

vercel bot commented Mar 24, 2024

@nihal467 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@nihal467
Copy link
Member

nihal467 commented Mar 26, 2024

image

@rithviknishad keep the same error message, don't change it, as it is more specific

@nihal467
Copy link
Member

image

add a '*' to the DOB field

@nihal467
Copy link
Member

image

keep the reflection in DD/MM/YYYY

@nihal467
Copy link
Member

@rash-27 dont push the changes, @rithviknishad is pushing it

@rash-27
Copy link
Contributor Author

rash-27 commented Mar 26, 2024

Okay

@khavinshankar
Copy link
Member

merging it, approved by @nihal467

@khavinshankar khavinshankar merged commit 5a8b9e8 into ohcnetwork:develop Mar 26, 2024
33 of 35 checks passed
Copy link

@rash-27 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@rash-27 rash-27 deleted the i7218 branch March 31, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure needs testing waiting for backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in details of user
4 participants